When React.Strict is used, polling does not automatically start when …

…a pollInterval is specified, startPolling must be explicitly called (#433)
ExpressLRS · Dec 7, 2022 · bef3430 · bef3430
1 parent 354f73f
commit bef3430
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/src/ui/components/SerialConnectionForm/index.tsx b/src/ui/components/SerialConnectionForm/index.tsx
@@ -32,9 +32,16 @@ const SerialConnectionForm: FunctionComponent<SerialConnectionFormProps> = (
 ) => {
   const { onConnect, serialDevice, baudRate } = props;
 
-  const { loading, data, error, previousData } = useAvailableDevicesListQuery({
-    pollInterval: 1000,
-  });
+  const { loading, data, error, previousData, startPolling, stopPolling } =
+    useAvailableDevicesListQuery();
+
+  useEffect(() => {
+    startPolling(1000);
+    return () => {
+      stopPolling();
+    };
+  }, [startPolling, stopPolling]);
+
   const options: Option[] =
     data?.availableDevicesList?.map((target) => ({
       label: `${target.path} ${target.manufacturer}`,

diff --git a/src/ui/components/SerialDeviceSelect/index.tsx b/src/ui/components/SerialDeviceSelect/index.tsx
@@ -42,9 +42,16 @@ const SerialDeviceSelect: FunctionComponent<SerialDeviceSelectProps> = (
 ) => {
   const { serialDevice, onChange } = props;
 
-  const { loading, data, error, previousData } = useAvailableDevicesListQuery({
-    pollInterval: 1000,
-  });
+  const { loading, data, error, previousData, startPolling, stopPolling } =
+    useAvailableDevicesListQuery();
+
+  useEffect(() => {
+    startPolling(1000);
+    return () => {
+      stopPolling();
+    };
+  }, [startPolling, stopPolling]);
+
   const options: Option[] =
     data?.availableDevicesList?.map((target) => ({
       label: `${target.path} ${target.manufacturer}`,