Condition engine refactor and improvements — JSON Schema Validation #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVincentX
force-pushed
the
feat/condition-refactor
branch
from
9156caf to
67b2633
Compare
XVincentX
force-pushed
the
feat/condition-refactor
branch
from
6c67292 to
5be5221
Compare
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 89.15% 89.16% +0.01%
==========================================
Files 135 136 +1
Lines 3652 3674 +22
==========================================
+ Hits 3256 3276 +20
- Misses 396 398 +2
Continue to review full report at Codecov.
|
XVincentX
force-pushed
the
feat/condition-refactor
branch
from
04bc022 to
d61ea23
Compare
XVincentX
force-pushed
the
feat/condition-refactor
branch
3 times, most recently
from
7743147 to
d671d7b
Compare
XVincentX
force-pushed
the
feat/condition-refactor
branch
from
d671d7b to
b3323bb
Compare
XVincentX
force-pushed
the
feat/condition-refactor
branch
from
d943c59 to
62d9c4a
Compare
XVincentX
force-pushed
the
feat/condition-refactor
branch
from
62d9c4a to
1720823
Compare
XVincentX
force-pushed
the
feat/condition-refactor
branch
from
74a2334 to
cb37447
Compare
XVincentX
force-pushed
the
feat/condition-refactor
branch
from
801e9ec to
69b39db
Compare
XVincentX
changed the title
gatherchou
pushed a commit
to yilu-tech/express-gateway
that referenced
this pull request
Jul 29, 2021
…xpressGateway#882) * unify code style with conditions * show condition name correctly * refactor pipeline construction * put default condition in the schema * provide more data and logger * restore conditionConfig check * fix typo * validate conditions ahead of the time * temporany compatibility * check condition presence * fix test text * add condition indirection layer * provide validation for sub conditions * json schema validator * add flatmap for node 8 and 10 * use logError to show stuff or not * Compatibility with old plugins * move it in conditions * kill matchEgCondition * add test for json schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a refactor of the condition engine solving couple of limitations that were starting be an issue.
As a result of the changes, we're now able to validate the condition's JSON Schema before starting the gateway (catching problems ahead of the time instead of catching them during the runtime).
Summary:
matchEgConditionfunction. This helps making conditions and policy kind of the same thing; it should be easier to maintain.I've also implemented the JSON Schema Validate condition which can be used around, helping moving the OpenAPI integration forward. Right now it works by using kind of a secret property called
middlewaresso that they can be installed before evaluating the current policy. Kind of hacky, but it does the job.Connect #591
Closes #591