Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lint mechanism #529

Merged
merged 3 commits into from
Nov 13, 2017
Merged

Replace lint mechanism #529

merged 3 commits into from
Nov 13, 2017

Conversation

XVincentX
Copy link
Member

This PR will replace the pre-commit mechanism with lint-staged in order to only check the staged files and not the entire codebase everytime you commit.

@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

Merging #529 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         223      223           
  Lines        9495     9495           
=======================================
  Hits         8754     8754           
  Misses        741      741

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e337834...11981f2. Read the comment docs.

Copy link
Contributor

@DrMegavolt DrMegavolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrMegavolt DrMegavolt merged commit 49774a3 into master Nov 13, 2017
@DrMegavolt DrMegavolt deleted the feat/replace-lint-mechanism branch November 13, 2017 14:40
@DrMegavolt DrMegavolt removed the test label Nov 13, 2017
DrMegavolt pushed a commit that referenced this pull request Nov 13, 2017
* Replace pre-commit with lint-staged

* Add husky for precommit check
gatherchou pushed a commit to yilu-tech/express-gateway that referenced this pull request Jul 29, 2021
* Replace pre-commit with lint-staged

* Add husky for precommit check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants