Automate docker and npm publish part #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=====================================
Coverage 92% 92%
=====================================
Files 219 219
Lines 9280 9280
=====================================
Hits 8538 8538
Misses 742 742Continue to review full report at Codecov.
|
XVincentX
force-pushed
the
feature/autodeploy
branch
from
531288f to
84671a4
Compare
DrMegavolt
reviewed
Nov 1, 2017
| @@ -20,9 +20,36 @@ jobs: | |||
| - run: npm install | |||
| - run: npm test | |||
|
|
|||
| deploy: | |||
| docker: | |||
| - image: circleci/node:8 | |||
There was a problem hiding this comment.
does it really has to be circleci node ?
There was a problem hiding this comment.
Not really.
Technically it could be any docker image that has got npm; however I decided to reuse the same because
- As it has been already downloaded and built, it should start almost immediately.
- The
deployjob has a transitive dependency on node8 build — therefore it's kind of a natural dependency.
If you have another idea around that feel free to shout them!
There was a problem hiding this comment.
I got it, this is image for build process, not for release. good
gatherchou
pushed a commit
to yilu-tech/express-gateway
that referenced
this pull request
Jul 29, 2021
…odeploy Automate docker and npm publish part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should hopefully allevieate the amount of work we have to do when we want to
release a new express-gateway version.
It will listen on the master branch and if a new tag with vx.y.z pattern comes in, it will build and publish both npm package and docker images related, and update the 'latest' tag as well.
We need to set both docker and npm credentials through env variables (//cc @kevinswiber )
Unfortunately I can't test this properly without deploying something — so once merged we could give it a try on eg 1.4 or any bug fix that'll come along us.
Connects #495 closes #495