Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefer-const rule to eslint and fix the previous occurrences #455

Merged
merged 3 commits into from
Oct 3, 2017

Conversation

XVincentX
Copy link
Member

Nothing fancy happening here.

@XVincentX XVincentX requested a review from DrMegavolt October 1, 2017 19:31
@codecov
Copy link

codecov bot commented Oct 1, 2017

Codecov Report

Merging #455 into master will not change coverage.
The diff coverage is 98.49%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files         226      226           
  Lines        9271     9271           
=======================================
  Hits         8427     8427           
  Misses        844      844
Impacted Files Coverage Δ
test/routing/host-regex.test.js 96.29% <100%> (ø) ⬆️
lib/rest/routes/users.js 83.01% <100%> (ø) ⬆️
lib/admin/apps.js 100% <100%> (ø) ⬆️
test/routing/host-capture.all.test.js 95.45% <100%> (ø) ⬆️
lib/policies/key-auth/passport-apikey-strategy.js 86.36% <100%> (ø) ⬆️
test/services/tokens.test.js 77.96% <100%> (ø) ⬆️
lib/services/consumers/user.service.js 86.17% <100%> (ø) ⬆️
lib/gateway/pipelines.js 92.8% <100%> (ø) ⬆️
bin/environment.js 97.1% <100%> (ø) ⬆️
test/services/authorization-codes.test.js 96.96% <100%> (ø) ⬆️
... and 118 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49413e...3c2e2c8. Read the comment docs.

@XVincentX XVincentX merged commit c0535fe into master Oct 3, 2017
@XVincentX XVincentX deleted the feature/prefer-const branch October 3, 2017 09:17
gatherchou pushed a commit to yilu-tech/express-gateway that referenced this pull request Jul 29, 2021
…fer-const

Add prefer-const rule to eslint and fix the previous occurrences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants