Provide plugin typings #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
=======================================
Coverage 90.89% 90.89%
=======================================
Files 226 226
Lines 9271 9271
=======================================
Hits 8427 8427
Misses 844 844Continue to review full report at Codecov.
|
DrMegavolt
approved these changes
Sep 30, 2017
|
Yeah - I was thinking about the JWT one |
|
I don't agree with JWT, because this is extremely popular and will be forked a lot. So having it TS is a barrier for that. There are some smaller examples like web sockets, advanced logger (with connectors to ELK etc.). They can be TS no problem, as well as ES6 style with import\export |
|
All right - it seems reasonable. |
gatherchou
pushed a commit
to yilu-tech/express-gateway
that referenced
this pull request
Jul 29, 2021
…ugin-typings Provide plugin typings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects #433 closes #433
This pull request provides basic Typings for the exposed plugin interface. People working with Typescript or even Javascript will receive a great help while writing code.