Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding alias to make it accept dir name #373

Merged
merged 1 commit into from
Aug 9, 2017

Conversation

DrMegavolt
Copy link
Contributor

eg gateway create -t getting-started -n test -d "/var/folders/mm/kl51qfl11db9fhm3fp01mkt40000gn/T/a4d9a6ac-57b2-4e15-9ac2-f3cce392dfd3"

fails to use provided folder and shows prompt

-d was ignored because in code it uses argv.directory but only d and dir are registered as aliases

@DrMegavolt DrMegavolt self-assigned this Aug 9, 2017
@DrMegavolt DrMegavolt requested a review from kevinswiber August 9, 2017 10:02
@codecov
Copy link

codecov bot commented Aug 9, 2017

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         193      193           
  Lines        8199     8199           
=======================================
  Hits         7458     7458           
  Misses        741      741
Impacted Files Coverage Δ
bin/generators/gateway/create.js 20.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2353d5c...ae25851. Read the comment docs.

Copy link
Member

@kevinswiber kevinswiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevinswiber kevinswiber merged commit 4158485 into master Aug 9, 2017
@kevinswiber kevinswiber deleted the bugfix/eg_gateway_create_directory_option branch August 9, 2017 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants