Adding OAuth2 authorization code e2e test. Closes #359. #371
Conversation
| }); | ||
|
|
||
| const driver = new webdriver.Builder() | ||
| .forBrowser('chrome') |
There was a problem hiding this comment.
I believe we should use phantomjs as headless driver to no have chrome pop up.
There was a problem hiding this comment.
ok, I see headless mode, still it requires chrome to be installed. phantomjs is just a dev dependency
There was a problem hiding this comment.
@DrMegavolt, chromedriver is just a dev dependency, too. However, CircleCI is bombing on it for some reason, complaining about the chromedriver version. Might try phantom to see if it fairs better on CI. (https://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/phantomjs.html)
There was a problem hiding this comment.
@kevinswiber chromedriver is a plugin to selenium that operates on real chrome browser. you need to have chrome on it's own installed. PhantomJS is a browser on it's own not a plugin, so when you have phantomjs plugin for selenium that operates against phantomjs browser it will work. And PhantomJS browser can be a dependency
There was a problem hiding this comment.
Seems to have worked. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 90.84% 90.96% +0.11%
==========================================
Files 188 193 +5
Lines 8062 8199 +137
==========================================
+ Hits 7324 7458 +134
- Misses 738 741 +3
Continue to review full report at Codecov.
|
No description provided.