Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/standardize entitiy create output connect #311 #343

Merged
merged 3 commits into from
Jul 26, 2017

Conversation

DrMegavolt
Copy link
Contributor

No description provided.

@DrMegavolt DrMegavolt self-assigned this Jul 26, 2017
@DrMegavolt DrMegavolt requested a review from kevinswiber July 26, 2017 13:58
@codecov
Copy link

codecov bot commented Jul 26, 2017

Codecov Report

Merging #343 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   90.74%   90.78%   +0.03%     
==========================================
  Files         187      187              
  Lines        7960     7983      +23     
==========================================
+ Hits         7223     7247      +24     
+ Misses        737      736       -1
Impacted Files Coverage Δ
bin/eg-generator.js 100% <ø> (ø) ⬆️
bin/generators/apps/create.js 94.11% <100%> (+0.07%) ⬆️
bin/generators/users/create.js 96.1% <100%> (+0.05%) ⬆️
test/cli/users/create.test.js 94.65% <100%> (+0.53%) ⬆️
test/cli/credentials/create.test.js 95.14% <100%> (+1.2%) ⬆️
test/cli/apps/create.test.js 93.78% <100%> (+0.14%) ⬆️
bin/generators/credentials/create.js 77.65% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84b4604...c83a3a8. Read the comment docs.

Copy link
Member

@kevinswiber kevinswiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinswiber kevinswiber merged commit 059837b into master Jul 26, 2017
@kevinswiber kevinswiber deleted the feature/standardize-entitiy-create-output branch July 26, 2017 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants