Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Onyx.cleanCache #81

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Fix: Onyx.cleanCache #81

merged 2 commits into from
Jun 9, 2021

Commits on Jun 9, 2021

  1. fix: disconnect affects the cached value for getAllKeys 

    `OnyxCache.remove` was renamed to `drop` and updated so that it
does not remove the `key` but only the value
This way the result of `getAllKeys` is unaffected

Related to Expensify#76
    @kidroca
    kidroca committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    d322991 View commit details
    Browse the repository at this point in the history

  2. refactor: update Onyx.remove and Onyx.clear to cache a null value 

    When we remove values from storage we cache that the value was removed from storage
The next time someone requests this value we can tell them right away it's null
and they don't need to wait to read this from storage
    @kidroca
    kidroca committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    b0cf26c View commit details
    Browse the repository at this point in the history