Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Onyx.clear to accept passed in keys to preserve, and use multiSet to clear storage #214

Merged
merged 22 commits into from
Dec 9, 2022
Merged

Update Onyx.clear to accept passed in keys to preserve, and use multiSet to clear storage #214

merged 22 commits into from
Dec 9, 2022

Commits on Dec 6, 2022

  1. Update Onyx.clear to accept passed in default values

    @yuwenmemon
    yuwenmemon committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    4b6ec53 View commit details
    Browse the repository at this point in the history

  2. Add in tests

    @yuwenmemon
    yuwenmemon committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    317a617 View commit details
    Browse the repository at this point in the history

  3. Fix copy pasta mistake

    @yuwenmemon
    yuwenmemon committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c660897 View commit details
    Browse the repository at this point in the history

  4. Fix typo in docs

    @yuwenmemon
    yuwenmemon committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6fe4b3e View commit details
    Browse the repository at this point in the history

  5. Swtich to keyStatesToPreserve

    @yuwenmemon
    yuwenmemon committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    af6f771 View commit details
    Browse the repository at this point in the history

  6. Update test comments/linting

    @yuwenmemon
    yuwenmemon committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    9a82d54 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Restore cleared storage values in addition to skipping resetting the … 

    …cache entry
    @yuwenmemon
    yuwenmemon committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    56c674b View commit details
    Browse the repository at this point in the history

  2. Update tests

    @yuwenmemon
    yuwenmemon committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    f239a7f View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Preserve additional defaults using multiset

    @yuwenmemon
    yuwenmemon committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2c2daab View commit details
    Browse the repository at this point in the history

  2. Update tests because we'll now always have storage match the cache

    @yuwenmemon
    yuwenmemon committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2c5b82b View commit details
    Browse the repository at this point in the history

  3. Update docs

    @yuwenmemon
    yuwenmemon committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    29ba481 View commit details
    Browse the repository at this point in the history

  4. Update tests

    @yuwenmemon
    yuwenmemon committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    851da7d View commit details
    Browse the repository at this point in the history

  5. Update to make sure that keysToPreserve takes precedence over default… 

    … keys
    @yuwenmemon
    yuwenmemon committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    335aca0 View commit details
    Browse the repository at this point in the history

  6. Update lib/Onyx.js 

    Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>
    @yuwenmemon @marcaaron
    yuwenmemon and marcaaron authored Dec 8, 2022
    Configuration menu
    Copy the full SHA
    885dd11 View commit details
    Browse the repository at this point in the history

  7. Remove blank line

    @yuwenmemon
    yuwenmemon committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1f54370 View commit details
    Browse the repository at this point in the history

  8. PR comments

    @yuwenmemon
    yuwenmemon committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7f7f06b View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Update lib/Onyx.js 

    Co-authored-by: Tim Golen <tgolen@expensify.com>
    @yuwenmemon @tgolen
    yuwenmemon and tgolen authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d1a14b2 View commit details
    Browse the repository at this point in the history

  2. Update lib/Onyx.js 

    Co-authored-by: Tim Golen <tgolen@expensify.com>
    @yuwenmemon @tgolen
    yuwenmemon and tgolen authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3bfcc8c View commit details
    Browse the repository at this point in the history

  3. Update tests/unit/onyxMultiMergeWebStorageTest.js 

    Co-authored-by: Tim Golen <tgolen@expensify.com>
    @yuwenmemon @tgolen
    yuwenmemon and tgolen authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5203294 View commit details
    Browse the repository at this point in the history

  4. Make method more clear with both variable names and comments

    @yuwenmemon
    yuwenmemon committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    220a8ee View commit details
    Browse the repository at this point in the history

  5. Update lib/Onyx.js 

    Co-authored-by: Neil Marcellini <neil@expensify.com>
    @yuwenmemon @neil-marcellini
    yuwenmemon and neil-marcellini authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    420e677 View commit details
    Browse the repository at this point in the history

  6. Update comments / var names

    @yuwenmemon
    yuwenmemon committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c26f6e5 View commit details
    Browse the repository at this point in the history