-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention background alignment #594
Conversation
@289Adam289 does this fix your problem? |
It's better but i still experience issues with cursor position. It behaves weirdly when input is empty and is slightly moved the left while typing. Screen.Recording.2025-01-08.at.09.50.56.mov |
Yeah cursor seems wonky, but the blue background now looks better right? |
Background looks a lot better, but i agree with @Kicu that it might be a little off although nab. |
@289Adam289 I've added a fix, please check if the cursor overlapping text, or a shifted background is still happening |
Every thing fixed and looks great. I've also tested this pr on E/App web and I couldn't find any regressions. Screen.Recording.2025-01-16.at.17.22.55.mov |
@289Adam289 I've added one more fix, for the vertically moving text issue you've found, you can test if it fixed the problem 😄 Video of the bugScreen.Recording.2025-01-17.at.10.44.14.mov |
I've tested the single line web on the E/App and example app. Everything seems to be working really well. Thanks for taking care of this! Screen.Recording.2025-01-20.at.15.45.15.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🚀 🚀 🚀 |
Details
Related Issues
GH_LINK
Manual Tests
Linked PRs