Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention background alignment #594

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

BartoszGrajdek
Copy link
Collaborator

Details

Related Issues

GH_LINK

Manual Tests

Linked PRs

@BartoszGrajdek
Copy link
Collaborator Author

@289Adam289 does this fix your problem?

@289Adam289
Copy link

It's better but i still experience issues with cursor position. It behaves weirdly when input is empty and is slightly moved the left while typing.

Screen.Recording.2025-01-08.at.09.50.56.mov

@Kicu
Copy link
Member

Kicu commented Jan 8, 2025

Yeah cursor seems wonky, but the blue background now looks better right?
Honestly to me it still feels like there is a bit more background above the text than below the text 😅 but I think its a tiny thing, and not everyone might notice.

@289Adam289
Copy link

Background looks a lot better, but i agree with @Kicu that it might be a little off although nab.

@BartoszGrajdek
Copy link
Collaborator Author

@289Adam289 I've added a fix, please check if the cursor overlapping text, or a shifted background is still happening

@289Adam289
Copy link

Every thing fixed and looks great. I've also tested this pr on E/App web and I couldn't find any regressions.

Screen.Recording.2025-01-16.at.17.22.55.mov

@BartoszGrajdek
Copy link
Collaborator Author

@289Adam289 I've added one more fix, for the vertically moving text issue you've found, you can test if it fixed the problem 😄

Video of the bug
Screen.Recording.2025-01-17.at.10.44.14.mov

@289Adam289
Copy link

I've tested the single line web on the E/App and example app. Everything seems to be working really well. Thanks for taking care of this!

Screen.Recording.2025-01-20.at.15.45.15.mov

Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BartoszGrajdek BartoszGrajdek merged commit a10c75d into main Jan 21, 2025
5 checks passed
@BartoszGrajdek BartoszGrajdek deleted the @BartoszGrajdek/single-line-background branch January 21, 2025 08:59
@os-botify
Copy link
Contributor

os-botify bot commented Jan 21, 2025

🚀 Published to npm in 0.1.221 🎉

@Kicu
Copy link
Member

Kicu commented Jan 21, 2025

🚀 🚀 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants