Introduce MarkdownRange class on iOS
#555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds an intermediate step in formatting
NSAttributedStringon iOS. Instead of usingjsi::Valuefrom parser directly, first we populatemarkdownRangesarray consisting ofMarkdownRangeobjects. Then, we callapplyRangeToAttributedStringwhile iterating over the array.The main benefit is that now we can memoize the parser output on the native side since holding
jsi::Valueis not recommended. It will also make it simpler to split the implementation into smaller parts.Related Issues
GH_LINK
Manual Tests
Linked PRs