Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useCallback dependency arrays #261

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented Apr 3, 2024

Details

This PR fixes onSubmitEditing prop that wasn't updated in handleKeyPress function. Also this PR adds react-hooks plugin to .eslintrc.js

Related Issues

GH_LINK

Manual Tests

Linked PRs

Expensify/App#39189

tomekzaw
tomekzaw previously approved these changes Apr 3, 2024
@Skalakid Skalakid requested a review from tomekzaw April 3, 2024 14:11
.eslintrc.js Outdated Show resolved Hide resolved
@Skalakid Skalakid changed the title Fix onSubmitEditing prop Fix useCallback dependency arrays Apr 3, 2024
@Skalakid Skalakid requested a review from tomekzaw April 3, 2024 15:39
@Skalakid Skalakid merged commit 2e3257f into main Apr 3, 2024
2 checks passed
@Skalakid Skalakid deleted the @Skalakid/fix-onSubmitEditing-prop branch April 3, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants