Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: italic syntax removing a preceding character #546

Conversation

eh2077
Copy link
Contributor

@eh2077 eh2077 commented Jun 12, 2023

Fixed Issues

$ Expensify/App#20111

Tests

  1. Go to chat and add a comment
h_ello_
  1. Verify that the comment text is h_ello_ and it's not rendered as italic style.

QA

Same

@eh2077 eh2077 requested a review from a team as a code owner June 12, 2023 16:54
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team June 12, 2023 16:54
@amyevans amyevans self-requested a review June 12, 2023 17:23
@amyevans
Copy link
Contributor

@mollfpr please review

lib/ExpensiMark.js Outdated Show resolved Hide resolved
@mollfpr
Copy link
Contributor

mollfpr commented Jun 12, 2023

Thanks @amyevans will review it soon!

@marcochavezf marcochavezf removed their request for review June 12, 2023 21:43
@marcochavezf
Copy link
Contributor

Removing myself as reviewer, it's weird that PullerBear assigned me 😄

@eh2077 eh2077 requested review from amyevans and mollfpr June 12, 2023 23:57
amyevans
amyevans previously approved these changes Jun 13, 2023
@eh2077 eh2077 changed the title 20111 fix italic syntax removing a preceding character fix: italic syntax removing a preceding character Jun 13, 2023
@eh2077 eh2077 force-pushed the 20111-fix-italic-syntax-removing-a-preceding-character branch from f300d81 to 85df9f8 Compare June 13, 2023 17:50
@eh2077 eh2077 requested a review from amyevans June 13, 2023 17:51
Copy link
Contributor

@mollfpr mollfpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well on my local 👍

cc @amyevans

@amyevans amyevans merged commit 80d0afd into Expensify:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants