Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade html-entities version #545

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

hungvu193
Copy link
Contributor

Fixed Issues

$ Expensify/App#19790

Tests

  1. Open any chat
  2. Send an invalid html character, eg: �
  3. Verify that the app isn't crashed and there's no console error.

QA

Same as Tests.

Result

Screen.Recording.2023-05-30.at.13.17.59.mov

@hungvu193 hungvu193 requested a review from a team as a code owner June 8, 2023 23:17
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from chiragsalian and removed request for a team June 8, 2023 23:17
@hungvu193
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@hungvu193
Copy link
Contributor Author

recheck

@chiragsalian
Copy link
Contributor

I think there is a mistake here. I would expect a package.lock file to be uploaded also since package.json was updated. Can you verify and update it?

Also once this is merged will you also be updating the package.json file in App repo too so make use of the updated expensify-common code?

@hungvu193
Copy link
Contributor Author

Thanks @chiragsalian , that's my bad, I thought I shouldn't packageloc.json 😂 .

Also once this is merged will you also be updating the package.json file in App repo too so make use of the updated expensify-common code?

Yeah, but we also have a discussion here about html-entities in our App (Expensify/App#19790 (comment)). Because I saw that we didn't have any usage of it.

Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian
Copy link
Contributor

I thought I shouldn't packageloc.json

haha all cool, every once in a while an internal engineer also forgets to update package lock. Funny enough we have a bot to check for this mistake and post in the issue but i think the bot isn't enabled for expensify-common repo.

Either way, thanks for pushing it up 🙂

@chiragsalian chiragsalian merged commit 743108f into Expensify:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants