-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade html-entities version #545
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
7d60b79
to
8ebcf35
Compare
8ebcf35
to
7edf4f1
Compare
I think there is a mistake here. I would expect a package.lock file to be uploaded also since package.json was updated. Can you verify and update it? Also once this is merged will you also be updating the package.json file in App repo too so make use of the updated expensify-common code? |
Thanks @chiragsalian , that's my bad, I thought I shouldn't packageloc.json 😂 .
Yeah, but we also have a discussion here about html-entities in our App (Expensify/App#19790 (comment)). Because I saw that we didn't have any usage of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
haha all cool, every once in a while an internal engineer also forgets to update package lock. Funny enough we have a bot to check for this mistake and post in the issue but i think the bot isn't enabled for expensify-common repo. Either way, thanks for pushing it up 🙂 |
Fixed Issues
$ Expensify/App#19790
Tests
QA
Same as Tests.
Result
Screen.Recording.2023-05-30.at.13.17.59.mov