Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emoji anchor text with hyperlink #536

Merged

Conversation

dukenv0307
Copy link
Contributor

@dukenv0307 dukenv0307 commented May 15, 2023

Details

Emoji only is accepted as an anchor text and it doesn't look pleasing to the eye. We don't want emoji-only text to be anchor text for links.

Fixed Issues

$ Expensify/App#18386
PROPOSAL: Expensify/App#18386 (comment)

Tests

To test, we need to update the hash commit of expensify-common package in App repo into 0f363d1eb6731aac34c20a0102822557253ac6a4 like this:
"expensify-common": "git+ssh://git@github.com/expensify/expensifycommon.git#0f363d1eb6731aac34c20a0102822557253ac6a4"

Open any chat and:

  1. Put an emoji inside of square brackets "[]" and put a link inside of parenthesis "()"
  2. Post the comment
  3. Verify emoji text not to be anchor text for links
  • Verify that no errors appear in the JS console

QA Steps

Open any chat and:

  1. Put an emoji inside of square brackets "[]" and put a link inside of parenthesis "()"
  2. Post the comment
  3. Verify emoji text not to be anchor text for links
  • Verify that no errors appear in the JS console

Screenshots/Videos

Web
Screen.Recording.2023-05-15.at.16.12.05.mp4
Mobile Web - Chrome
processed-5789CDCD-44B0-47A0-A4F1-66E9C06280D7-DD46FAA8-F954-4B0B-9263-0D3D6D2F6AC3.mp4
Mobile Web - Safari
processed-22203F0E-BFD9-4745-AF6F-6A18F5FAAF7A-8D8A193E-7357-4A28-B555-137A77C429CA.mp4
Desktop
Screen.Recording.2023-05-15.at.20.12.36.mp4
IOS
Screen.Recording.2023-05-15.at.16.08.40.mp4
Android
Screen.Recording.2023-05-15.at.22.06.05.mp4

@dukenv0307 dukenv0307 requested a review from a team as a code owner May 15, 2023 15:07
@melvin-bot melvin-bot bot requested review from Gonals and removed request for a team May 15, 2023 15:08
@dukenv0307 dukenv0307 marked this pull request as draft May 15, 2023 15:11
@dukenv0307 dukenv0307 force-pushed the fix/emoji-anchor-text-with-hyperlink branch from b70ade7 to 0e31a94 Compare May 15, 2023 15:46
@dukenv0307 dukenv0307 marked this pull request as ready for review May 16, 2023 03:04
@dukenv0307 dukenv0307 force-pushed the fix/emoji-anchor-text-with-hyperlink branch from 3936443 to a554878 Compare May 16, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants