Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Add Expensify Card Feed Name #167

Merged
merged 1 commit into from
Aug 15, 2019
Merged

[NO QA] Add Expensify Card Feed Name #167

merged 1 commit into from
Aug 15, 2019

Conversation

stitesExpensify
Copy link
Contributor

@johnmlee101 will you please review this?

New constant for Expensify Card feed name

Fixed Issues

$ https://github.com/Expensify/Web-Expensify/pull/25592#discussion_r314231252

Tests

  1. Pull this and https://github.com/Expensify/Web-Expensify/pull/25592
  2. Enable localJS for prod
  3. Supportal into svfg@expensify.com
  4. Go to domain control
  5. Make sure the settings tab doesn't show for the expensify card

@stitesExpensify stitesExpensify self-assigned this Aug 15, 2019
@johnmlee101 johnmlee101 merged commit 2860ff4 into master Aug 15, 2019
@stitesExpensify stitesExpensify deleted the stites-cardFeedName branch August 15, 2019 18:19
@MelvinBot MelvinBot mentioned this pull request Jun 20, 2023
Closed
@MelvinBot MelvinBot mentioned this pull request Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmlee101 johnmlee101 johnmlee101 approved these changes

Assignees

@stitesExpensify stitesExpensify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stitesExpensify @johnmlee101