Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fixed modal animations" #2833

Merged
merged 1 commit into from
May 12, 2021
Merged

Revert "fixed modal animations" #2833

merged 1 commit into from
May 12, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented May 12, 2021

Reverts #2680

Resolves #2825

@roryabraham roryabraham requested a review from a team as a code owner May 12, 2021 22:10
@MelvinBot MelvinBot requested review from francoisl and removed request for a team May 12, 2021 22:10
@roryabraham roryabraham mentioned this pull request May 12, 2021
5 tasks
@roryabraham roryabraham self-assigned this May 12, 2021
@parasharrajat
Copy link
Member

parasharrajat commented May 12, 2021

@marcaaron @roryabraham
So I have one fix for this problem.
1.On native devices we don't need to wait for transitionEnd as animations already run on the native driver. So we can use InteractionManager for that purpose on native devices.
2. Why we chose transitionEnd over InteractionManager is that the web does not have InteractionManager support. But it seems IOS does not work well with transition events on navigation.

So in short we can use InteractionManager for native and transitionEnd for web, desktop, and mobile web.
Ready to drop a PR after confirmation.

@francoisl francoisl merged commit 97173b1 into main May 12, 2021
@francoisl francoisl deleted the revert-2680-animations branch May 12, 2021 22:37
@francoisl
Copy link
Contributor

Woops I had this open in another tab and noticed the tests finished, so I merged without seeing your comment. It was still ok to merge, right?

@roryabraham
Copy link
Contributor Author

Yep, no worries @francoisl !

Sounds reasonable to me @parasharrajat, but maybe we should also open an issue in the react-navigation repo to report the inconsistent transitionEnd behavior we're seeing on iOS

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.42-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.44-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Infinite loading spinners when trying to launch anything from the CreateMenu
4 participants