-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert iOS Safari auto scrollback #8571
Conversation
@roryabraham What is the next step for this? Are we going to revert it or something else? |
Hmmm ... I don't remember why I closed this. It might have been accidental. I think we do want to revert this auto scrollback feature. Do you agree? |
Yeah, I agree to revert it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We
I think we should proceed with this. It is creating more issues. |
# Conflicts: # src/libs/iOSSafariAutoScrollback/index.web.js
Opened up for reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @roryabraham in version: 1.1.58-0 🚀
|
🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀
|
Details
This PR reverts #6413, which never really worked as expected and caused #8135.
There was a lot of context and conversation behind these changes. Reverting this PR will bring back this bug, which I think is the lesser of two evils (not as bad as #8135, which actually affects the usability of our app).
There was discussion of another solution, but I think we can reopen #5894 and make it external so they can figure out how to make it work with the address bar on top or bottom (which is a configurable setting as of iOS 15).
Fixed Issues
$ #8135
Tests / QA Steps
None, this is just a revert.