Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add separate assertions for deploy comments, fix bug #7161

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

roryabraham
Copy link
Contributor

Details

This fixes an edge case that is causing duplicate deploy comments, such as here.

Fixed Issues

$ n/a

Tests

Added new assertions to automated unit test.

QA Steps

I've updated the QA steps of #6906 to cover this change.

@roryabraham roryabraham requested a review from a team as a code owner January 12, 2022 17:52
@roryabraham roryabraham self-assigned this Jan 12, 2022
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team January 12, 2022 17:52
@Jag96 Jag96 merged commit 67302fc into main Jan 12, 2022
@Jag96 Jag96 deleted the Rory-FixDuplicateDeployComment branch January 12, 2022 19:15
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.28-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.29-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants