Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: margin for Save button on Password page #6600

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #6497

Tests | QA Steps

  1. Open the Change Password page from the Settings menu page.
  2. Observe the gap around the Save Button.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop | Mobile Web | iOS | Android

image

@parasharrajat parasharrajat requested a review from a team as a code owner December 6, 2021 19:39
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team December 6, 2021 19:39
@stitesExpensify stitesExpensify merged commit 339c19f into Expensify:main Dec 6, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @stitesExpensify in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the password-page branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants