Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ImageView zoom scale dynamic with window size #6599

Closed
wants to merge 3 commits into from

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Dec 6, 2021

Details

Following up on #6535, cc @railway17

Fixed Issues

$ none

Tests / QA Steps

  1. Prepare a very long image.
  2. Send the image to someone.
  3. Click the image thumbnail in the chatbox.
  4. Verify modal opens to display the image.
  5. Verify image is center aligned.
  6. Check the cursor while hovering around the image.
  7. Check the zoom in and zoom out functionality.
  8. Resize the window and make sure the image zoom region adjusts accordingly
  9. Prepare a very wide image and send it to another.
  10. Repeat steps 2-8 with the wide image.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@roryabraham roryabraham self-assigned this Dec 6, 2021
@roryabraham roryabraham changed the title Clean up ImageView component Make ImageView zoom scale dynamic with window size Jan 12, 2022
@roryabraham
Copy link
Contributor Author

Don't remember the context here, going to just close this.

@roryabraham roryabraham deleted the Rory-CleanupImage branch July 6, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant