Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added properties to fix layout on ipad #6597

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

danieldoglas
Copy link
Contributor

Details

Fixed Issues

$ #6486

Tests

For example:

  1. Open new.E on iPad portrait
  2. Login page should show with full text showing.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS (iPad)
  • Android

Screenshots

Web

image

iOS

image

@danieldoglas danieldoglas requested a review from a team as a code owner December 6, 2021 18:21
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team December 6, 2021 18:21
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well :shipit:

iPad

Web

@NikkiWines NikkiWines merged commit 4e2d82d into main Dec 6, 2021
@NikkiWines NikkiWines deleted the dsilva_welcomeScreen branch December 6, 2021 20:10
@OSBotify
Copy link
Contributor

OSBotify commented Dec 6, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@kakajann
Copy link
Contributor

kakajann commented Dec 6, 2021

Lol, did you just copy my code :D Goodjob!

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @NikkiWines in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants