Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change pronoun input margin to value for grouped form elements #6586

Merged
merged 2 commits into from
Dec 5, 2021
Merged

change pronoun input margin to value for grouped form elements #6586

merged 2 commits into from
Dec 5, 2021

Conversation

anthony-hull
Copy link
Contributor

@anthony-hull anthony-hull commented Dec 5, 2021 •
edited
Loading

Details

Increased the margin between the pronoun elements.

Fixed Issues

$ #5556

QA Steps

  1. View Profile
  2. Change preferred pronouns to Self-select
  3. The margin between the pronoun form elements is equal to that between First name and Last name

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web
image

Tablet mobile web
image

Mobile Web
image

iOS
image

Android
image

@anthony-hull anthony-hull requested a review from a team as a code owner December 5, 2021 17:26
@MelvinBot MelvinBot requested review from parasharrajat and puneetlath and removed request for a team December 5, 2021 17:26
parasharrajat
parasharrajat suggested changes Dec 5, 2021
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It increases the gap between select dropdown and next element when there is no custom Pronoun input. Could you please fix that?
it should not affect the UI when the custom input is hidden. Could you please test it carefully?

@anthony-hull
Copy link
Contributor Author

I'm very sorry! You are right, even simple changes need full attention.

@anthony-hull
move margin to conditional element
57a04ec 
this avoids margin being present when the optional pronouns input filed isn't present
@anthony-hull
Copy link
Contributor Author

image
image

parasharrajat
parasharrajat approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

All yours @puneetlath.

puneetlath
puneetlath approved these changes Dec 5, 2021
View reviewed changes
Copy link
Contributor

@puneetlath puneetlath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@puneetlath puneetlath merged commit 01b7b60 into Expensify:main Dec 5, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Dec 5, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 6, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @puneetlath in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Dec 8, 2021
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneetlath puneetlath puneetlath approved these changes

@parasharrajat parasharrajat parasharrajat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anthony-hull @OSBotify @puneetlath @parasharrajat