Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP STAGING] Fix redirect_uri for Plaid web #6578

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Dec 3, 2021

Details

cc @nickmurray47 The redirect_uri sent on web is not valid and so the link token does not return from the API.

2021-12-03_07-08-12

Fixed Issues

Deploy blocker -> #6571
https://github.com/Expensify/Expensify/issues/187320

Tests / QA Steps

  1. Create workspace
  2. Connect bank account
  3. Choose Plaid option
  4. Verify the Plaid modal appears and there is no infinite spinner

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner December 3, 2021 17:13
@marcaaron marcaaron self-assigned this Dec 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team December 3, 2021 17:13
@marcaaron marcaaron changed the title Fix redirect_uri for Plaid web [CP STAGING] Fix redirect_uri for Plaid web Dec 3, 2021
@marcaaron marcaaron merged commit a44cd3a into main Dec 3, 2021
@marcaaron marcaaron deleted the marcaaron-fixPlaidRedirectURI branch December 3, 2021 18:24
github-actions bot pushed a commit that referenced this pull request Dec 3, 2021
[CP STAGING] Fix redirect_uri for Plaid web

(cherry picked from commit a44cd3a)
@nickmurray47
Copy link
Contributor

Tested and confirmed this works on staging

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @marcaaron in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants