Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remaining pages for workspace #6557

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Dec 1, 2021

Details

Follow up #6543

Fixed Issues

$ #6496

Tests | QA Steps

Same as preceding PR.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

output_file.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner December 1, 2021 11:00
@parasharrajat
Copy link
Member Author

@Gonals Please review...

@MelvinBot MelvinBot requested review from thienlnam and removed request for a team December 1, 2021 11:01
@parasharrajat
Copy link
Member Author

@thienlnam I don't know why E2E test failed but we should be good to merge here.

@thienlnam
Copy link
Contributor

Hmm, are E2E tests failing on other PRs? If not then I don't think we should merge this. Going to re-run the test to see if it was just a flakey test

@parasharrajat
Copy link
Member Author

We are good.. @thienlnam

@thienlnam thienlnam merged commit 970c2d5 into Expensify:main Dec 2, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Dec 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @thienlnam in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@mvtglobally
Copy link

@parasharrajat Do we need to do any additional QA for this PR on top of QA for #6543?
if yes, can you share steps?

@marcaaron marcaaron added the DeployBlockerCash This issue or pull request should block deployment label Dec 7, 2021
@marcaaron
Copy link
Contributor

I think this PR is possible breaking the VBA flow -> #6620

Did a git bisect and it led me here.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants