Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove div usage in Onfido Web" #6548

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Revert "Remove div usage in Onfido Web" #6548

merged 1 commit into from
Nov 30, 2021

Conversation

luacmartins
Copy link
Contributor

Details

Reverts #6454

cc @francoisl

Fixed Issues

$ #6534

Tests

  1. Launch the Desktop app and login
  2. Tap on [+] and select Send money > enter amount > next
  3. Enter the email of a user you will send money to in the field 'Name, email or phone"
  4. Tap on Continue for "Verify identity" page
  5. Verify that the Onfido page shows up.

QA Steps

Same as above.

@luacmartins luacmartins requested a review from a team as a code owner November 30, 2021 20:37
@luacmartins luacmartins self-assigned this Nov 30, 2021
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from Beamanator and removed request for a team November 30, 2021 20:38
@luacmartins luacmartins changed the title [No QA] Revert "Remove div usage in Onfido Web" Revert "Remove div usage in Onfido Web" Nov 30, 2021
@francoisl francoisl merged commit 8502c5b into main Nov 30, 2021
@francoisl francoisl deleted the revert-6454-cmartins-removeOnfidoDiv branch November 30, 2021 21:30
@francoisl
Copy link
Contributor

Merging because Alex is out for the day and this is a deploy blocker.

github-actions bot pushed a commit that referenced this pull request Nov 30, 2021
@francoisl
Merge pull request #6548 from Expensify/revert-6454-cmartins-removeOn…
10614f9 
…fidoDiv

Revert "Remove div usage in Onfido Web"

(cherry picked from commit 8502c5b)
@OSBotify OSBotify mentioned this pull request Nov 30, 2021
Merged
@mvtglobally mvtglobally mentioned this pull request Dec 1, 2021
Closed
69 tasks
@OSBotify OSBotify mentioned this pull request Dec 6, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @francoisl in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisl francoisl francoisl approved these changes

@Beamanator Beamanator Awaiting requested review from Beamanator

Assignees

@luacmartins luacmartins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @francoisl @OSBotify