Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOQA] Fix broken link to app structure section of readme #6536

Merged
merged 2 commits into from
Nov 30, 2021
Merged

[NOQA] Fix broken link to app structure section of readme #6536

merged 2 commits into from
Nov 30, 2021

Conversation

Julesssss
Copy link
Contributor

Details

Simply fix a broken link in the table of contents.

Tests

  • Open the Readme against this branch
  • Tap 'App Structure and Conventions' in the table of contents
  • You should be navigated to the 'App Structure and Conventions' section of the readme

QA Steps

NA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

N/A

@Julesssss Julesssss requested a review from a team November 30, 2021 14:10
@Julesssss Julesssss self-assigned this Nov 30, 2021
@MelvinBot MelvinBot requested review from AndrewGable and removed request for a team November 30, 2021 14:10
@AndrewGable AndrewGable merged commit 93b268f into main Nov 30, 2021
@AndrewGable AndrewGable deleted the jules-updateReadmeContentsTableLink branch November 30, 2021 17:27
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 6, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @AndrewGable in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewGable AndrewGable AndrewGable approved these changes

Assignees

@Julesssss Julesssss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julesssss @OSBotify @AndrewGable