Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Enter key bubbling to the composer, on selecting LHN row via Enter #6515

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Block Enter key bubbling to the composer, on selecting LHN row via Enter #6515

merged 1 commit into from
Nov 29, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #6386

Tests | QA Steps

  1. Click on the LHN on the top to not have anything selected
  2. Using the Tab key, select a chat
  3. Click Enter to open the page

Tested On

  • Web
  • Mobile Web (Not affected)
  • Desktop
  • iOS (Not affected)
  • Android (Not affected)

Screenshots

Web | Desktop

output_file.mp4

Mobile Web

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner November 29, 2021 20:12
@MelvinBot MelvinBot requested review from mountiny and removed request for a team November 29, 2021 20:12
mountiny
mountiny approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mountiny mountiny merged commit d471d34 into Expensify:main Nov 29, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 6, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @mountiny in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Dec 8, 2021
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the event-bubble branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @mountiny