Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed logic to use 2 decimals instead of 3 #6499

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

danieldoglas
Copy link
Contributor

@danieldoglas danieldoglas commented Nov 29, 2021

cc: @rushatgabhane

Details

We were allowing 3 decimal cases in the amount field on Send Money/Request money. Changed it to 2.

Fixed Issues

$ #6286

QA Steps:

  1. Navigate to a conversation
  2. Request money
  3. Verify you cannot enter an amount with 3 decimal places.

@danieldoglas danieldoglas requested a review from a team as a code owner November 29, 2021 16:10
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team November 29, 2021 16:11
@danieldoglas
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@TomatoToaster
Copy link
Contributor

TomatoToaster commented Nov 29, 2021

LGTM feel free to merge when the E2E tests finish. @danieldoglas Could you also add the reproduction steps from the original issue to this one for the QA steps? I think it's fine to copy and paste it.

@TomatoToaster TomatoToaster merged commit de6aca9 into main Nov 29, 2021
@TomatoToaster TomatoToaster deleted the dsilva_changeIOUAmountToTwoDecimals branch November 29, 2021 21:20
@OSBotify
Copy link
Contributor

@danieldoglas, Great job getting your first Expensify/App pull request over the finish line! 🎉

I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:

  1. Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
  2. Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
  3. Once your PR is deployed to production, we start a 7-day timer ⏰. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. 💰

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @TomatoToaster in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants