Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IOU EnablePayment route #6469

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Fix IOU EnablePayment route #6469

merged 3 commits into from
Nov 30, 2021

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Nov 24, 2021 •
edited
Loading

Details

Moved the IOU_Enable_Payments under IOU_Send

Fixed Issues

$ #6473

Tests

  1. Launch the Desktop app and login.
  2. Tap on [+] and select Send money > enter amount > next.
  3. Enter the email of a user you will send money to in the field 'Name, email or phone".
  4. Tap on Continue for "Verify identity" page.
  5. Verify that the EnablePayments page opens. On web verify that the url is /iou/enable-payments.
  6. Verify that you can navigate back.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mweb.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins self-assigned this Nov 24, 2021
@luacmartins luacmartins marked this pull request as ready for review November 24, 2021 19:24
@luacmartins luacmartins requested a review from a team as a code owner November 24, 2021 19:24
@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team November 24, 2021 19:25
@luacmartins
Copy link
Contributor Author

Bumping for review!

danieldoglas
danieldoglas approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@danieldoglas danieldoglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieldoglas danieldoglas merged commit 26f167e into main Nov 30, 2021
@danieldoglas danieldoglas deleted the cmartins-fixEnablePaymentRoute branch November 30, 2021 16:49
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Dec 6, 2021
Closed
95 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Dec 7, 2021

🚀 Deployed to staging by @danieldoglas in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldoglas danieldoglas danieldoglas approved these changes

Assignees

@luacmartins luacmartins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luacmartins @OSBotify @danieldoglas