-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix white space around top and bottom edges of extra long images #6384
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@tgolen Gentle reminder. Looks like the workflow requires an approval to proceed as this is my first PR here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! I was away on vacation.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀
|
Details
This PR fixes an issue where a white empty space was shown at the top and bottom of extra long images.
There was a 1px border around the thumbnail image which was not taken into account while calculating the image dimensions. This resulted in the rendered image from getting squished due to box-sizing. To fix this thumbnail styles are now applied to a parent View which wraps the fixed width container that embeds the image.
Fixed Issues
$ #5162
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android