Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Run CP workflow on macOS #6344

Merged
merged 1 commit into from
Nov 17, 2021
Merged

[No QA] Run CP workflow on macOS #6344

merged 1 commit into from
Nov 17, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Coming from #6199, CP workflow is failing because it relies on PListBuddy, which is only available on macOS.

Fixed Issues

Fixes this failure: https://github.com/Expensify/App/runs/4233889892?check_suite_focus=true

Tests

  1. Merge this PR.
  2. Manually CP Pass translateX prop to TextInput component #6341
  3. See if it works this time.

@roryabraham roryabraham self-assigned this Nov 17, 2021
@roryabraham roryabraham requested a review from a team as a code owner November 17, 2021 04:33
@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team November 17, 2021 04:34
luacmartins
luacmartins approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luacmartins
Copy link
Contributor

Feel free to self-merge.

@Jag96 Jag96 merged commit 0afac43 into main Nov 17, 2021
@Jag96 Jag96 deleted the Rory-FixCPPListBuddy branch November 17, 2021 16:42
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Jag96
Copy link
Contributor

Jag96 commented Nov 17, 2021

Looks like part of the CP workflow relies on linux, so we'll need a new fix

Run repo-sync/pull-request@65194d8015be7624d231796ddee1cd52a5023cb3
  with:
    source_branch: Jag96-cherry-pick-staging-6341
    destination_branch: staging
    github_token: ***
    pr_title: 🍒 Cherry pick PR #6341 to staging 🍒
    pr_body: 🍒 Cherry pick https://github.com/Expensify/App/pull/6341 to staging 🍒
    pr_label: automerge
  env:
    NEW_VERSION: 1.1.15-5
Error: Container action is only supported on Linux

@Jag96 Jag96 mentioned this pull request Nov 17, 2021
Merged
@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@luacmartins luacmartins luacmartins approved these changes

@danieldoglas danieldoglas Awaiting requested review from danieldoglas

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roryabraham @luacmartins @OSBotify @Jag96