Remove early return from isFromPublicDomain if domain is public #6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timszot
approved these changes
Nov 17, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We added the ability to auto approving Expensify Cards for users with private domain as secondary logins. This PR removes the early return from
isFromPublicDomainso we can determine if the user has Expensify Cards enabled in their account.Fixed Issues
$ #6337
Tests
@gmail.com.isUsingExpensifyCardsis set to false.QA Steps
Steps above.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android