Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix switching to manual address when adding bank account #6332

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Fix switching to manual address when adding bank account #6332

merged 2 commits into from
Nov 16, 2021

Conversation

francoisl
Copy link
Contributor

@francoisl francoisl commented Nov 16, 2021 •
edited
Loading

Pullerbear review (@cead22)

Details

When adding a bank account, fix the Can't find your address? Enter it manually link.

Fixed Issues

$ #6323

Tests / QA

  1. Create a workspace
  2. Select the "Connect Bank Account"
  3. Fill in the details until the step 3 "Personal Information"
  4. Start typing an address in the "Personal Address" input, select an option in the dropdown below
  5. Click "Can't find your address?"
  6. Make sure the UI refreshes with the inputs to manually enter your address
  7. Make sure the City, State, and Zip Code inputs are prepopulated with the values from the address you just selected previously
Screen.Recording.2021-11-16.at.12.41.13.PM.mov

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@francoisl francoisl requested a review from a team as a code owner November 16, 2021 18:53
@francoisl francoisl self-assigned this Nov 16, 2021
@MelvinBot MelvinBot requested review from cead22 and removed request for a team November 16, 2021 18:54
@Jag96
Copy link
Contributor

Jag96 commented Nov 16, 2021

Adding CP Staging label since this fixes a deploy blocker

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@francoisl
Copy link
Contributor Author

Ah yes thanks, I forgot.

Jag96
Jag96 reviewed Nov 16, 2021
View reviewed changes
src/pages/ReimbursementAccount/IdentityForm.js
@@ -133,7 +133,7 @@ const IdentityForm = (props) => {
errorText={props.errors.ssnLast4 ? props.translate('bankAccount.error.ssnLast4') : ''}
maxLength={CONST.BANK_ACCOUNT.MAX_LENGTH.SSN}
/>
{props.manualAddress ? (
{props.values.manualAddress ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the other props need to be updated as well? For example, value={props.city} is still used even though city is inside values in the propTypes definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh yeah good thinking, probably. I was too focused on fixing the issue and didn't think to check the rest, I'll check now.

@francoisl
Copy link
Contributor Author

Updated code and test steps.

@francoisl francoisl requested a review from Jag96 November 16, 2021 20:45
Jag96
Jag96 approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, confirmed it works on mobile as well 🚀

@Jag96 Jag96 merged commit 24faffc into main Nov 16, 2021
@Jag96 Jag96 deleted the francois-fixManualAddressBank branch November 16, 2021 22:25
github-actions bot pushed a commit that referenced this pull request Nov 16, 2021
@Jag96
Merge pull request #6332 from Expensify/francois-fixManualAddressBank
d89455e 
Fix switching to manual address when adding bank account

(cherry picked from commit 24faffc)
This was referenced Nov 16, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @Jag96 in version: 1.1.15-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@cead22 cead22 Awaiting requested review from cead22

Assignees

@francoisl francoisl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francoisl @Jag96 @OSBotify