Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Deep link to add secondary login in OldDot" #6313

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

luacmartins
Copy link
Contributor

cc @mountiny

I forgot to put a hold on this PR and it went out before the Web-E one. Reverting until the Web-E gets merged. CP'ing to staging as the PR has been deployed to staging already.

Reverts #6176

@luacmartins luacmartins requested a review from a team as a code owner November 16, 2021 02:11
@luacmartins luacmartins self-assigned this Nov 16, 2021
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from Jag96 and removed request for a team November 16, 2021 02:11
@mountiny
Copy link
Contributor

Feel free to self-merge!

@luacmartins luacmartins removed the request for review from Jag96 November 16, 2021 02:15
@luacmartins luacmartins merged commit f59f3be into main Nov 16, 2021
@luacmartins luacmartins deleted the revert-6176-cmartins-privateSecondaryLogin branch November 16, 2021 03:06
github-actions bot pushed a commit that referenced this pull request Nov 16, 2021
…econdaryLogin

Revert "Deep link to add secondary login in OldDot"

(cherry picked from commit f59f3be)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.15-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants