Allow spaces and special chars in phone number username #6293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanitize the phone input before sending to backend.
chiragsalian
requested changes
Nov 16, 2021
|
@chiragsalian Added the same for RequestCallPage as well. |
chiragsalian
requested changes
Nov 17, 2021
src/pages/RequestCallPage.js
Outdated
| @@ -106,13 +106,13 @@ class RequestCallPage extends Component { | |||
| Growl.error(this.props.translate('requestCallPage.growlMessageNoPersonalPolicy'), 3000); | |||
| return; | |||
| } | |||
|
|
|||
| const phoneNumber = this.state.phoneNumber.replace(/((?!\n)[()-\s\t])/g, ''); | |||
There was a problem hiding this comment.
The regex in this file has been repeated 4 times. It seems pretty useful as well so how about moving it to a lib file and calling it via a method like getPhoneNumberWithoutSpecialChars that would do the replace as well, or moving the regex to CONST. This way we can DRY up the code.
chiragsalian
approved these changes
Nov 18, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @chiragsalian in version: 1.1.15-18 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
#6227 (comment)
Fixed Issues
$ #6227
Tests | QA Steps
-,(,)or spaces (e.g. +1 (222) 222 2222)Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android