Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added download links to the workspace invite message #6292

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Added download links to the workspace invite message #6292

merged 2 commits into from
Nov 19, 2021

Conversation

akshayasalvi
Copy link
Contributor

@akshayasalvi akshayasalvi commented Nov 14, 2021 •
edited
Loading

Details

  • Added app download page link to the Workspace invite page

Fixed Issues

$ #5774

Tests

  1. Tested the email invite from all platforms
  2. Tested email link redirection
  3. Edited message content removing link

QA Steps

  1. Go to any workspace using sidebar
  2. Click on Manage Members
  3. Click on Invite button at the top
  4. The default welcome note should have use.expensify.com/download link in the message
  5. Enter any email address and click on Invite
  6. You should also receive the email with the use.expensify.com/download as a clickable link

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

email-screenshot

web-app-links

v2
image

Mobile Web

mweb-app-links

Desktop

desktop-app-links

iOS

ios-app-links

Android

android-app-links

@akshayasalvi akshayasalvi requested a review from a team as a code owner November 14, 2021 01:52
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team November 14, 2021 01:52
Beamanator
Beamanator requested changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you actually make this tiny text change? (also in the spanish translation) I think it's a bit clearer to users

src/languages/en.js Outdated Show resolved Hide resolved
@akshayasalvi
Copy link
Contributor Author

PR updated

@Beamanator Beamanator self-requested a review November 19, 2021 12:09
Beamanator
Beamanator approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work - thanks for sticking with this 👍

@Beamanator Beamanator merged commit 9ad3ec4 into Expensify:main Nov 19, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Nov 22, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Beamanator in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Nov 29, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

Assignees

@akshayasalvi akshayasalvi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshayasalvi @OSBotify @Beamanator