Reset instead of deleting achData #6257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
aldo-expensify
and removed request for
a team
aldo-expensify
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Tested on web, works. Looks good to me.
Leaving un-merged in case @marcaaron wants to have a look. @NikkiWines feel free to merge if you want.
marcaaron
approved these changes
Nov 6, 2021
| isInSetup: true, | ||
| domainLimit: 0, | ||
| currentStep: CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT, | ||
| }; |
There was a problem hiding this comment.
Thanks for catching this!!!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
Reset instead of deleting achData (cherry picked from commit b12eb5f)
|
🚀 Cherry-picked to staging by @francoisl in version: 1.1.14-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
70 tasks
|
🚀 Deployed to staging by @marcaaron in version: 1.1.14-5 🚀
|
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @marcaaron related to #5828
Details
Sets basic ACHData, including
currentStep, in case the user deletes their VBA and then immediately goes to add another.Previously we'd just wipe out the
reimbursementAccountonyx key so we'd get an error when trying to callAPI.BankAccount_SetupWithdrawalbecausecurrentStepwas missing.Fixed Issues
$ #6246
Tests
Same as QA steps
QA Steps
Tested On
Screenshots
Web
web.mp4
Mobile Web
Desktop
iOS
ios.mov
Android
android.mp4