-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request Call placeholder & messages updated #6178
Request Call placeholder & messages updated #6178
Conversation
@chiragsalian for the new messages text alignment looks odd. |
Good point. I think the error message should maybe be center-aligned. But it's better to rope in design for this so cc-ing @Expensify/design for thoughts/suggestions on how the error message should appear. |
I think the left-alignment is fine as it is. |
@chiragsalian bump! |
Seems the design team is okay with this! |
Will update the PR & let you know |
Updated PR |
@chiragsalian PR updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍. We're on a merge freeze at the moment till Monday so I'll merge it then 🙂
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @chiragsalian in version: 1.1.15-18 🚀
|
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
|
Details
Just place holder & phone number error message copy updates for Request a Call Modal.
Fixed Issues
$ #5945
Tests & QA Steps
2109400803
call
without entering any number to check the new error messages.Tested On
Screenshots
Web
Mobile Web
iOS
Android
Desktop