Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KeyboardSpacer component from NewChatPage #6099

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Remove KeyboardSpacer component from NewChatPage #6099

merged 1 commit into from
Oct 28, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Oct 28, 2021 •
edited
Loading

Fixed Issues

$ #6097

Tests / QA Steps.

  1. Run the app on a physical device.
  2. Click on the FAB and select New Chat.
  3. Verify that results in the list are not obscured.
  4. Close the new chat modal.
  5. Click on the FAB and select New Group.
  6. Verify that results in the list are not obscured.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

New Chat New Group
IMG_40C933BF7118-1 IMG_CACC2A48D871-1

Desktop

iOS

New Chat New Group
IMG_09FE61201532-1 IMG_D78696B16444-1

Android

New Chat New Group
image image

@roryabraham roryabraham requested a review from a team as a code owner October 28, 2021 18:09
@roryabraham roryabraham self-assigned this Oct 28, 2021
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team October 28, 2021 18:10
stitesExpensify
stitesExpensify approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@stitesExpensify stitesExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roryabraham roryabraham merged commit b110524 into main Oct 28, 2021
@roryabraham roryabraham deleted the Rory-FixKeyboardSpacerOnNewChatPage branch October 28, 2021 18:27
github-actions bot pushed a commit that referenced this pull request Oct 28, 2021
@roryabraham
Merge pull request #6099 from Expensify/Rory-FixKeyboardSpacerOnNewCh…
1b9dac9 
…atPage

(cherry picked from commit b110524)
This was referenced Oct 28, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Oct 28, 2021
Closed
29 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.10-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stitesExpensify stitesExpensify stitesExpensify approved these changes

@MonilBhavsar MonilBhavsar Awaiting requested review from MonilBhavsar

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roryabraham @OSBotify @stitesExpensify