Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Stg] Only navigate to Onfido if we're in the Send Money flow #6086

Merged
merged 6 commits into from
Oct 27, 2021
Merged

[CP Stg] Only navigate to Onfido if we're in the Send Money flow #6086

merged 6 commits into from
Oct 27, 2021

Conversation

nickmurray47
Copy link
Contributor

@nickmurray47 nickmurray47 commented Oct 27, 2021 •
edited by abecciv
Loading

Details

Moved the wallet check from the ButtonWithMenu component to IOUModal. Now we will only go to the Onfido flow once a user tries to pay.

Fixed Issues

$ #5928

Tests / QA Steps

  1. Using an account with a silver wallet (or no wallet), select the "Send Money" option in the global create menu.
  2. Select someone to send money to; it doesn't matter who. Type in any amount.
  3. Verify you are taken to the Confirmation page, and click on the "Pay with Expensify" option in green.
  4. Verify you are taken to the Onfido verification flow and that you don't proceed with the Send Money flow.
  5. Verify that clicking the close button in the header takes you back to your IOU request.
  6. Next, select the "Request Money" option in the global create menu.
  7. Follow the full flow to request money from anyone and verify the Onfido verification flow does not pop up.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Kapture 2021-10-27 at 13 48 56

Mobile Web

Desktop

Kapture 2021-10-27 at 15 03 03

iOS

Screen Shot 2021-10-27 at 2 19 19 PM
Screen Shot 2021-10-27 at 2 19 00 PM
Screen Shot 2021-10-27 at 2 18 54 PM

Android

Screen Shot 2021-10-27 at 2 43 02 PM

Screen Shot 2021-10-27 at 2 43 42 PM

Screen Shot 2021-10-27 at 2 43 20 PM

@nickmurray47 nickmurray47 self-assigned this Oct 27, 2021
@nickmurray47 nickmurray47 requested a review from a team as a code owner October 27, 2021 19:55
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team October 27, 2021 19:55
@nickmurray47 nickmurray47 changed the title [CP Stg] Only navigate to Onfido if we in the Send Money flow [CP Stg] Only navigate to Onfido if we're in the Send Money flow Oct 27, 2021
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

Luke9389
Luke9389 reviewed Oct 27, 2021
View reviewed changes
src/pages/iou/IOUModal.js Outdated Show resolved Hide resolved
Luke9389
Luke9389 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for that change.

@nickmurray47
Copy link
Contributor Author

nickmurray47 commented Oct 27, 2021 •
edited
Loading

These tests literally take multiple lifetimes :(

@nickmurray47
Copy link
Contributor Author

@jasperhuangg all you

@jasperhuangg jasperhuangg merged commit bdecb8f into main Oct 27, 2021
@jasperhuangg jasperhuangg deleted the nmurray-cp-fix-iou-navigation branch October 27, 2021 22:49
github-actions bot pushed a commit that referenced this pull request Oct 27, 2021
@jasperhuangg
Merge pull request #6086 from Expensify/nmurray-cp-fix-iou-navigation
b1cf4ef 
[CP Stg] Only navigate to Onfido if we're in the Send Money flow

(cherry picked from commit bdecb8f)
This was referenced Oct 27, 2021
Merged
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @jasperhuangg in version: 1.1.10-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify OSBotify mentioned this pull request Oct 28, 2021
Closed
29 tasks
@roryabraham
Copy link
Contributor

@nickmurray47 Can you please QA this on staging, and if it passes check it off on the deploy checklist

@nickmurray47
Copy link
Contributor Author

Will do rn

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @jasperhuangg in version: 1.1.10-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperhuangg jasperhuangg jasperhuangg approved these changes

@Luke9389 Luke9389 Luke9389 approved these changes

Assignees

@nickmurray47 nickmurray47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickmurray47 @OSBotify @roryabraham @jasperhuangg @Luke9389