Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AddressSearch related fields missing renaming in "Additional information" step #5975

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Add AddressSearch related fields missing renaming in "Additional information" step #5975

merged 2 commits into from
Oct 25, 2021

Conversation

aldo-expensify
Copy link
Contributor

@aldo-expensify aldo-expensify commented Oct 21, 2021 •
edited
Loading

Details

Just like with RequestorStep.js ("Personal Information" step), the field names in IdentityForm.js don't match anymore with the names we finally use to store them in each "Beneficial owner" in BeneficialOwnersStep.js ("Additional Information" step). Added field name mapping to translate them.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/181598

Tests / QA

  1. Create NewDot account, verify it, login
  2. Create a workspace and start the process of adding a VBA
  3. Go through the first, second and third step using (3) from this SO
  4. When you get to the "Additional information", check "Somebody else owns more than 25% of" to add a "Beneficial owner"
  5. Input an address and click on a result suggested by the autocomplete, then click "Save & Continue" (No need to fill all fields)
  6. Expected result: The "Personal address" field should not have an error

Screen Shot 2021-10-21 at 10 06 17 AM

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@aldo-expensify aldo-expensify requested a review from a team as a code owner October 21, 2021 17:06
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team October 21, 2021 17:06
aldo-expensify
aldo-expensify commented Oct 21, 2021
View reviewed changes
src/pages/ReimbursementAccount/RequestorStep.js
Comment on lines -92 to -95
street: 'requestorAddressStreet',
city: 'requestorAddressCity',
state: 'requestorAddressState',
zipCode: 'requestorAddressZipCode',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this because it looks like our old renaming and I see no reason to keep these entries.

@aldo-expensify aldo-expensify self-assigned this Oct 21, 2021
@aldo-expensify
Copy link
Contributor Author

I think @HorusGoul is OOO for today, should we merge? @TomatoToaster

@HorusGoul HorusGoul merged commit 79ba0fb into main Oct 25, 2021
@HorusGoul HorusGoul deleted the aldo_fix-addresssearch-contract-step branch October 25, 2021 09:38
@OSBotify OSBotify mentioned this pull request Oct 25, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @HorusGoul in version: 1.1.8-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@roryabraham roryabraham mentioned this pull request Oct 27, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorusGoul HorusGoul HorusGoul approved these changes

@TomatoToaster TomatoToaster TomatoToaster approved these changes

Assignees

@aldo-expensify aldo-expensify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aldo-expensify @OSBotify @HorusGoul @TomatoToaster