Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spinner on web #5955

Merged
merged 2 commits into from
Oct 25, 2021
Merged

fix: spinner on web #5955

merged 2 commits into from
Oct 25, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #5947

Tests | QA Steps

  1. Log in to New Expensify
  2. Open console tools > Network
  3. Set the page as Offline
  4. Set the page to Slow 3G

To test it on mobile, use the airplane mode with mobile data for steps 2 - 4.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop | Mobile Web

output_file.mp4

iOS

Android

output_file.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner October 19, 2021 23:44
@MelvinBot MelvinBot requested review from tgolen and removed request for a team October 19, 2021 23:44
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that userNativeDriver is used in quite a few other places. Should this be applied to all references?

@parasharrajat
Copy link
Member Author

If this does not work with loop only and then we should only apply here. We can change the name but I feel it's fine. In future RN web will use native web animation api and thus this flag will work.

@tgolen
Copy link
Contributor

tgolen commented Oct 21, 2021

Any idea what's going on with the failing E2E test?

@parasharrajat
Copy link
Member Author

@tgolen Finally tests are passed. we are good here.

@parasharrajat
Copy link
Member Author

@tgolen Ready for merge.

@tgolen tgolen merged commit fad1d29 into Expensify:main Oct 25, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @tgolen in version: 1.1.8-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@roryabraham
Copy link
Contributor

It really seems like this issue was only affecting web, right @parasharrajat? I did some testing on staging and it passed QA, but like Applause testers I'm not sure how to test this on iOS native.

@parasharrajat
Copy link
Member Author

Yes this only affects web.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants