Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IOU quote UI #5941

Merged
merged 1 commit into from
Oct 19, 2021
Merged

fix: IOU quote UI #5941

merged 1 commit into from
Oct 19, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #5757

Tests | QA Steps

  1. Navigate to a conversation
  2. Request money to the user
  3. Click on the empty area next to the IOU message in the conversation.
  4. Only clicking over the view details should open the IOU details.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

image

iOS

Android

Screenshot 2021-10-19 07:55:58

@parasharrajat parasharrajat requested a review from a team as a code owner October 19, 2021 02:26
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team October 19, 2021 02:26
chiragsalian
chiragsalian approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@chiragsalian chiragsalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chiragsalian chiragsalian merged commit d0abb52 into Expensify:main Oct 19, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @chiragsalian in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Oct 28, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the chat-ui branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @chiragsalian