Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'set password' copy #5925

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Fix 'set password' copy #5925

merged 2 commits into from
Oct 19, 2021

Conversation

flodnv
Copy link
Contributor

@flodnv flodnv commented Oct 18, 2021

Details

@pecanoro asking you to review this because the 2 spanish translation aren't the same and I wonder if I should update one of them?

Fixed Issues

$ #5871

Tests

  1. Create an account
  2. Click on the validation link
  3. Check copy:

Screen Shot 2021-10-18 at 3 45 23 PM

4. Go to change the password, check copy:

Screen Shot 2021-10-18 at 3 43 38 PM

QA Steps

Same as Tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

See above

@flodnv flodnv requested a review from pecanoro October 18, 2021 14:49
@flodnv flodnv self-assigned this Oct 18, 2021
@flodnv flodnv requested a review from a team as a code owner October 18, 2021 14:49
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team October 18, 2021 14:49
jasperhuangg
jasperhuangg previously approved these changes Oct 18, 2021
@pecanoro
Copy link
Contributor

oh yeah

For this one:

newPasswordPrompt: 'La nueva contraseña debe ser diferente de la antigua, tener al menos 8 caracteres,\n1 letra mayúscula, 1 letra minúscula y 1 número.',

For this one:

newPasswordPrompt: 'La contraseña debe tener al menos 8 caracteres, \n1 letra mayúscula, 1 letra minúscula y 1 número.',

@flodnv
Copy link
Contributor Author

flodnv commented Oct 19, 2021

Thanks! Updated.

@pecanoro pecanoro merged commit 88766ac into main Oct 19, 2021
@pecanoro pecanoro deleted the flo_newPasswordCopy branch October 19, 2021 16:07
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @pecanoro in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants