Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Clean out unused routes #5736

Merged
merged 2 commits into from
Oct 18, 2021
Merged

[No QA] Clean out unused routes #5736

merged 2 commits into from
Oct 18, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Removes a number of unused screens and routes.

Fixed Issues

$ none, just general cleanup.

Tests

Just general regression testing. Run the app and make sure various routes work.

QA Steps

None – just regression testing.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@roryabraham roryabraham self-assigned this Oct 8, 2021
@roryabraham roryabraham requested a review from a team as a code owner October 8, 2021 21:04
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team October 8, 2021 21:05
@roryabraham
Copy link
Contributor Author

cc @iwiznia 99% sure none of these routes are used anymore since we moved to the LoginWithShortLivedToken

Copy link
Contributor

@iwiznia iwiznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think these are all unsued now

Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a thorough clean up 👍

@Julesssss
Copy link
Contributor

Not merging due to N6 hold, just to be safe.

@Julesssss Julesssss changed the title Clean out unused routes [HOLD] Clean out unused routes Oct 11, 2021
@Julesssss Julesssss removed the n6-hold label Oct 18, 2021
@Julesssss
Copy link
Contributor

N6 hold is over, merging.

@Julesssss Julesssss changed the title [HOLD] Clean out unused routes Clean out unused routes Oct 18, 2021
@Julesssss Julesssss merged commit 5533b3b into main Oct 18, 2021
@Julesssss Julesssss deleted the Rory-CleanupUnusedRoutes branch October 18, 2021 14:02
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham changed the title Clean out unused routes [No QA] Clean out unused routes Oct 25, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@marcaaron
Copy link
Contributor

I think the ValidateLogin page should not have been removed in this PR. See this issue.

Maybe we assumed that because other routes with a /v were changing that all could be changed, but this behavior is now missing from the app.

class ValidateLoginPage extends Component {
componentDidMount() {
const accountID = lodashGet(this.props.route.params, 'accountID', '');
const validateCode = lodashGet(this.props.route.params, 'validateCode', '');
validateLogin(accountID, validateCode);
}
render() {
// Don't render anything here since we will redirect the user once we've attempted to validate their login
return null;
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants