Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tooltip sense & add missing tooltips #5733

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Added tooltip sense & add missing tooltips #5733

merged 6 commits into from
Oct 19, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Oct 8, 2021 •
edited
Loading

Details

  • Instant Tooltip.
  • Add missing tooltips.
  • cleanup.

Fixed Issues

$ #5347

Tests | QA Steps

  1. Open NewDot on Web.
  2. hover over any target that has a tooltip.
  3. Now move your cursor to another tooltip target within 1 sec.
  4. Tooltip should be shown immediately.
  5. Change multiple targets and the same behavior should be shown.
  6. Now move your cursor from tooltip target to an area that does not have any tooltip attached.
  7. Wait for 1 sec, move back your cursor over the tooltip target.
  8. Tooltip should show with animation and delay.
  9. Perform repeat steps 3-8 to observe the changed behavior (Instant tooltips).

Tested On

  • Web
  • Mobile Web (does not have tooltips)
  • Desktop
  • iOS (does not have tooltips)
  • Android (does not have tooltips)

Screenshots

Web

output_file.mp4

Mobile Web

Desktop

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner October 8, 2021 18:32
@MelvinBot MelvinBot requested review from mountiny and removed request for a team October 8, 2021 18:32
@parasharrajat
Copy link
Member Author

@mountiny please test it and let me know what do you think?

If this looks good, then I will move to the next step of "adding missing tooltips to leftover actions".

mountiny
mountiny reviewed Oct 10, 2021
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parasharrajat Tested this and love it! Great job Rajat 🎉

I have left just one styling comment to swap the order of the functions, otherwise code LGTM and feel free to continue with the other steps. Thank you for working on this improvement!

src/components/Tooltip/TooltipSense.js Outdated
Comment on lines 14 to 20
function isActive() {
return active === true;
}

function deactivate() {
return debouncedDeactivate();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: A bit nitty-gritty, but I would keep the order alphabetical same as you have it in the export default on lines 23-25.

@parasharrajat
Copy link
Member Author

Great. Thanks. I will finish it asap.

@mountiny
Copy link
Contributor

Thank you, I mean, it is not n6 polish so no need to rush on this one especially if you have some other issues, which are considered to be n6 polish. But feel free to go ahead for sure :)

@parasharrajat
Copy link
Member Author

@mountiny Changes done and ready.

@mountiny mountiny self-requested a review October 14, 2021 13:42
mountiny
mountiny approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, great job Rajat. As mentioned in the parent issue, I will keep this on hold for n6 as this was not requested as part on the polish and we want to avoid potential regressions as much as possible before the release.

Thank you very much for your work on this PR.

@mountiny mountiny changed the title Added tooltip sense & add missing tooltips [HOLD] Added tooltip sense & add missing tooltips Oct 14, 2021
@mountiny
Copy link
Contributor

Hi @parasharrajat, The n6-hold was lifted so we can go ahead with this one.

As this PR is touching more parts of code, I would prefer if we could merge main branch to any of the n6-hold PRs and re-test. I doubt there will be any regression here, but better safe than sorry. Thank you for understanding.

@mountiny mountiny changed the title [HOLD] Added tooltip sense & add missing tooltips Added tooltip sense & add missing tooltips Oct 19, 2021
@mountiny mountiny self-requested a review October 19, 2021 11:28
@parasharrajat
Copy link
Member Author

@mountiny All set.

@parasharrajat
Copy link
Member Author

@mountiny Ready for merge.

mountiny
mountiny approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your work on this and your patience @parasharrajat 🙇 Great job!

@mountiny mountiny merged commit ce7a759 into Expensify:main Oct 19, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Oct 23, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@BeeMargarida BeeMargarida mentioned this pull request Jun 30, 2023
Closed
6 tasks
@parasharrajat parasharrajat deleted the tooltip branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mountiny mountiny mountiny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @mountiny @OSBotify