Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lag between language switch on login page #5300

Merged
merged 4 commits into from
Oct 18, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #5068 (comment)

Tests | QA Steps

  1. Your language should be set to Spanish
  2. Go to the sign-in page
  3. Enter any email address or phone number
  4. Click on "Regresar" (Go back)
  5. Language will be set to Spanish without a delay

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

o-s-w.mp4

Mobile Web

o-s-m.mp4

Desktop

iOS

Android

o-s-a.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner September 16, 2021 17:00
@MelvinBot MelvinBot requested review from Julesssss and removed request for a team September 16, 2021 17:00
@@ -298,6 +298,16 @@ function continueSessionFromECom(accountID, validateCode, twoFactorAuthCode) {
});
}

/**
* Clear the creadentials and partial sign in session so the user can taken back to first Login step
Copy link
Contributor

@Julesssss Julesssss Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo: creadentials

Julesssss
Julesssss previously approved these changes Sep 17, 2021
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, but lets fix the typo.

@parasharrajat
Copy link
Member Author

Oops. Updated @Julesssss

Julesssss
Julesssss previously approved these changes Sep 17, 2021
@Julesssss
Copy link
Contributor

Holding due to N6.

@Julesssss Julesssss changed the title fix: lag between language switch on login page [N6-HOLD] fix: lag between language switch on login page Sep 17, 2021
@Julesssss Julesssss changed the title [N6-HOLD] fix: lag between language switch on login page fix: lag between language switch on login page Oct 18, 2021
@Julesssss Julesssss removed the n6-hold label Oct 18, 2021
@Julesssss
Copy link
Contributor

@parasharrajat this can be merged now, you just need to resolve the conflict 👍

@parasharrajat
Copy link
Member Author

@Julesssss All set.

@parasharrajat
Copy link
Member Author

Ready to merge.

@Julesssss
Copy link
Contributor

@parasharrajat thanks, the iOS build takes forever 😴

@Julesssss
Copy link
Contributor

Julesssss commented Oct 18, 2021

We've tested this against the latest main changes, good to merge.

@Julesssss Julesssss merged commit 61bbde6 into Expensify:main Oct 18, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the picker-lag branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants